Paused and archived routines no longer dispatch runs on cron ticks, manual runs, or webhook fires; suppressed cron slots advance without recording a fire.
A paused or archived routine still fires on cron, manual run, and webhook. Pause does not stop work.
Who is affected: Operators who pause or archive Office routines to stop agent work.
Result: Only active routines fire. Paused and archived routines stay quiet on every path.
| Affected users / trigger | Before | After | Required action | Source |
|---|---|---|---|---|
| Callers that run a paused, archived, or unrecognized-status routine manually or by webhook | The request dispatches a run and returns 200. | The request returns 409 with error_code routine_not_firing and the observed status. | Set the routine status to active before firing, or handle the 409 refusal. | apps/backend/internal/office/routines/handler.go |
| Operators who rely on paused routines firing on their cron schedule | Due cron slots dispatch runs while the routine is paused. | Due cron slots advance past now with no run row, no wakeup, and no last_fired_at stamp. | Resume the routine to active to receive fires again; missed slots during pause are not replayed. | apps/backend/internal/office/routines/service.go |
| Entry point | Before | After | Source |
|---|---|---|---|
| Office Routines list | A paused routine still shows a next-fire countdown. | A non-firing routine shows Off and hides the next-fire countdown. | apps/web/app/office/routines/routine-row.tsx |
| Office Routine detail, Run now action | Run now on a paused routine shows a generic failure. | Run now on a paused routine shows localized copy naming the status, and the schedule card shows no next fire. | apps/web/app/office/routines/[id]/routine-detail-view.tsx |
Every fire path reads the routine and checks CanFire before it claims, dispatches, or renders.
flowchart TD
Cron[TickScheduledTriggers] --> Read1[GetRoutineFromConfig]
Manual[FireManual] --> Gate[RoutineStatus.CanFire]
Webhook[fireWebhookTrigger] --> Gate
Read1 --> Gate
Gate -- fires --> Claim[ClaimTrigger and dispatch run]
Gate -- suppressed --> Advance[AdvanceTriggerWithoutFiring]
Gate -- refused --> Refuse[HTTP 409 routine_not_firing]
Refuse --> UI[Web UI localized toast]Drag to pan. Use the + and − buttons to zoom. Click a node to open the full code. The arrows show how the parts interact.
drag to pan · +/− to zoom · click a node for details
The type gates every fire path with one byte-exact allowlist check.
type RoutineStatus string
const (
RoutineStatusActive RoutineStatus = "active"
RoutineStatusPaused RoutineStatus = "paused"
RoutineStatusArchived RoutineStatus = "archived"
)
func (s RoutineStatus) CanFire() bool {
return s == RoutineStatusActive || s == ""
}The cron worker reads the routine first and suppresses non-firing slots without claiming.
routine, err := s.GetRoutineFromConfig(ctx, trigger.RoutineID)
if err != nil {
return nil
}
if !models.RoutineStatus(routine.Status).CanFire() {
return s.suppressCronSlot(ctx, trigger, routine, now)
}
claimed, err := s.repo.ClaimTrigger(ctx, trigger.ID, *trigger.NextRunAt)next, err := s.computeSuppressionCursor(trigger, now)
if err != nil {
return nil
}
advanced, err := s.repo.AdvanceTriggerWithoutFiring(ctx, trigger.ID, *trigger.NextRunAt, next)
if !advanced {
return nil
}
s.logger.Info("routine slot suppressed",
zap.String("routine_id", routine.ID),
zap.String("status", routine.Status))The write moves next_run_at by compare-and-set and never touches last_fired_at.
func (r *Repository) AdvanceTriggerWithoutFiring(
ctx context.Context, triggerID string, oldNextRunAt, newNextRunAt time.Time,
) (bool, error) {
res, err := r.db.ExecContext(ctx, r.db.Rebind(`
UPDATE office_routine_triggers
SET next_run_at = ?, updated_at = ?
WHERE id = ? AND next_run_at = ?
`), newNextRunAt, time.Now().UTC(), triggerID, oldNextRunAt)
if err != nil {
return false, err
}
rows, err := res.RowsAffected()
return rows > 0, err
}Both routes refuse non-firing routines with one shared 409 body.
run, err := h.svc.FireManual(c.Request.Context(), c.Param("id"), req.Variables)
if err != nil {
var notFiring *RoutineNotFiringError
if errors.As(err, ¬Firing) {
c.JSON(http.StatusConflict, routineNotFiringBody(notFiring.Status))
return
}
writeDispatchError(c, err)
return
}if !models.RoutineStatus(routine.Status).CanFire() {
c.JSON(http.StatusConflict, routineNotFiringBody(routine.Status))
return
}
func routineNotFiringBody(status string) gin.H {
return gin.H{
"error": fmt.Sprintf("routine cannot fire: status is %q", status),
"error_code": RoutineNotFiringErrorCode,
"status": status,
}
}The UI hides next-fire times and maps the 409 code to localized copy.
export function isRoutineFiring(status: string): boolean {
return status === "active" || status === "";
}export const ROUTINE_NOT_FIRING_ERROR_CODE = "routine_not_firing";
export function routineNotFiringMessage(error: unknown, t: Translate, fallbackKey: string): string {
if (isRoutineNotFiringError(error)) {
return t("office:routineNotFiring", { status: refusedStatus(error, t) });
}
if (error instanceof Error && error.message.trim()) return error.message;
return t(fallbackKey);
}const isActive = isRoutineFiring(routine.status);
const nextFire = isActive ? nextFireText(t, triggers) : "";The type gates every fire path with one byte-exact allowlist check.
type RoutineStatus string
const (
RoutineStatusActive RoutineStatus = "active"
RoutineStatusPaused RoutineStatus = "paused"
RoutineStatusArchived RoutineStatus = "archived"
)
func (s RoutineStatus) CanFire() bool {
return s == RoutineStatusActive || s == ""
}The cron worker reads the routine first and suppresses non-firing slots without claiming.
routine, err := s.GetRoutineFromConfig(ctx, trigger.RoutineID)
if err != nil {
return nil
}
if !models.RoutineStatus(routine.Status).CanFire() {
return s.suppressCronSlot(ctx, trigger, routine, now)
}
claimed, err := s.repo.ClaimTrigger(ctx, trigger.ID, *trigger.NextRunAt)next, err := s.computeSuppressionCursor(trigger, now)
if err != nil {
return nil
}
advanced, err := s.repo.AdvanceTriggerWithoutFiring(ctx, trigger.ID, *trigger.NextRunAt, next)
if !advanced {
return nil
}
s.logger.Info("routine slot suppressed",
zap.String("routine_id", routine.ID),
zap.String("status", routine.Status))The write moves next_run_at by compare-and-set and never touches last_fired_at.
func (r *Repository) AdvanceTriggerWithoutFiring(
ctx context.Context, triggerID string, oldNextRunAt, newNextRunAt time.Time,
) (bool, error) {
res, err := r.db.ExecContext(ctx, r.db.Rebind(`
UPDATE office_routine_triggers
SET next_run_at = ?, updated_at = ?
WHERE id = ? AND next_run_at = ?
`), newNextRunAt, time.Now().UTC(), triggerID, oldNextRunAt)
if err != nil {
return false, err
}
rows, err := res.RowsAffected()
return rows > 0, err
}Both routes refuse non-firing routines with one shared 409 body.
run, err := h.svc.FireManual(c.Request.Context(), c.Param("id"), req.Variables)
if err != nil {
var notFiring *RoutineNotFiringError
if errors.As(err, ¬Firing) {
c.JSON(http.StatusConflict, routineNotFiringBody(notFiring.Status))
return
}
writeDispatchError(c, err)
return
}if !models.RoutineStatus(routine.Status).CanFire() {
c.JSON(http.StatusConflict, routineNotFiringBody(routine.Status))
return
}
func routineNotFiringBody(status string) gin.H {
return gin.H{
"error": fmt.Sprintf("routine cannot fire: status is %q", status),
"error_code": RoutineNotFiringErrorCode,
"status": status,
}
}The UI hides next-fire times and maps the 409 code to localized copy.
export function isRoutineFiring(status: string): boolean {
return status === "active" || status === "";
}export const ROUTINE_NOT_FIRING_ERROR_CODE = "routine_not_firing";
export function routineNotFiringMessage(error: unknown, t: Translate, fallbackKey: string): string {
if (isRoutineNotFiringError(error)) {
return t("office:routineNotFiring", { status: refusedStatus(error, t) });
}
if (error instanceof Error && error.message.trim()) return error.message;
return t(fallbackKey);
}const isActive = isRoutineFiring(routine.status);
const nextFire = isActive ? nextFireText(t, triggers) : "";